Skip to content

Update provider version and test source #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2025
Merged

Update provider version and test source #43

merged 2 commits into from
Jul 3, 2025
+7 −8

Conversation

@iamar7
Copy link
Member

@iamar7 iamar7 commented Jun 30, 2025 •
edited
Loading

Description

Update provider version and test source

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@iamar7 iamar7 requested a review from shemau as a code owner June 30, 2025 19:24
@iamar7 iamar7 mentioned this pull request Jun 30, 2025
Merged
1 task
@iamar7
Copy link
Member Author

iamar7 commented Jul 1, 2025

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Jul 2, 2025 •
edited
Loading

Since the event-streams module requires a minimum IBM provider version of 1.79.2, both the basic and advanced examples require 1.79.2 as the minimum. However, the solution does not include event-streams as a target, so it is being deployed with version 1.79.0.

Therefore, I’m planning to update the minimum required version in the basic example to 1.79.2 and will add a comment referencing this issue as the reason.

@iamar7
Copy link
Member Author

iamar7 commented Jul 2, 2025

/run pipeline

@iamar7 iamar7 self-assigned this Jul 2, 2025
shemau
shemau approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shemau
Copy link
Contributor

shemau commented Jul 2, 2025

This is a change to a test and an example. I can not see why a release is required.

@iamar7
Copy link
Member Author

iamar7 commented Jul 2, 2025

This is a change to a test and an example. I can not see why a release is required.

Updated the release notes

@maheshwarishikha maheshwarishikha merged commit ca712d0 into main Jul 3, 2025
2 checks passed
@maheshwarishikha maheshwarishikha deleted the anam-patch branch July 3, 2025 12:51
@terraform-ibm-modules-ops
Copy link
Contributor

terraform-ibm-modules-ops commented Jul 4, 2025

🎉 This PR is included in version 1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shemau shemau shemau approved these changes

Assignees

@iamar7 iamar7

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@iamar7 @shemau @terraform-ibm-modules-ops @maheshwarishikha